RFR: JDK-8331732 : [PPC64] Unify and optimize code which converts != 0 to 1 [v17]

Amit Kumar amitkumar at openjdk.org
Sat Jun 29 09:18:19 UTC 2024


On Sat, 29 Jun 2024 06:44:38 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> Maybe this needs to be enforced during build then ?

In this type of conversion we get a warning, And hotspot code treats all of the warnings as error. So this should break the build. 

But what I suspect is that as registers are being treated as integers, we can do this `Register temp = 1`. This is valid syntax.  So with `normalise_bool(result, true)` you set `Register dst = result`, `Register temp=1(true)` and `is_64bit` was considered `default`. Seems like there is nothing wrong syntax-wise. Hence no warnings were generated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19886#discussion_r1659676446


More information about the hotspot-dev mailing list