RFR: 8327652: S390x: Implements SLP support [v2]
Amit Kumar
amitkumar at openjdk.org
Mon Mar 18 02:15:27 UTC 2024
On Fri, 15 Mar 2024 13:40:29 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> src/hotspot/share/opto/machnode.hpp line 146:
>>
>>> 144: }
>>> 145: #endif
>>> 146: #if defined(AARCH64)
>>
>> can't we use #elif here ?
>
> why? no other platform does that.
will there be any issue if we do:
#elif defined(AARCH64)
instead of
#endif
#if defined(AARCH64)
The above one seems a bit better.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18162#discussion_r1527690087
More information about the hotspot-dev
mailing list