RFR: 8327652: S390x: Implements SLP support [v7]

Lutz Schmidt lucy at openjdk.org
Tue Mar 26 15:42:33 UTC 2024


On Mon, 18 Mar 2024 02:12:29 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> why? no other platform does that.
>
> will there be any issue if we do:
> 
> #elif defined(AARCH64)
> 
> instead of 
> 
> #endif
> #if defined(AARCH64)
> 
> 
> The above one seems a bit better.

This would just be another way to tell the preprocessor do the same thing. As it is, it's common practice at many places. Don't do "I like this better" changes in common code. That will involve you in lengthy discussions at least.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18162#discussion_r1537917531


More information about the hotspot-dev mailing list