RFR: 8327652: S390x: Implements SLP support [v4]

Sidraya Jayagond sjayagond at openjdk.org
Wed Mar 20 09:27:23 UTC 2024


On Tue, 19 Mar 2024 15:21:37 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Sidraya Jayagond has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use Op_VecX instead of Op_RegF
>>   
>>   Signed-off-by: Sidraya <sidraya.jayagond at ibm.com>
>
> src/hotspot/cpu/s390/s390.ad line 7473:
> 
>> 7471: // Sqrt float precision
>> 7472: instruct sqrtF_reg(regF dst, regF src) %{
>> 7473:   match(Set dst (SqrtF src));
> 
> Did the old code cause problems? Required nodes not matched? Maybe this should get fixed in a separate PR for backports?

[JDK-8308277](https://bugs.openjdk.org/browse/JDK-8308277)  This one was done for RISCV platform. If I do not make this change vectorization for float squreroot (Match.sqrt()) does not happen on s390x.  Unlike RISCV I did not see ConvF2D -> ConvD2F IR Node sequence on s390x.
Shall I raise a separate PR for this. ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18162#discussion_r1531741200


More information about the hotspot-dev mailing list