RFR: 8312132: Add tracking of multiple address spaces in NMT [v5]

Johan Sjölen jsjolen at openjdk.org
Fri Mar 22 16:25:24 UTC 2024


On Fri, 22 Mar 2024 14:29:31 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Include os.inline.hpp
>
> src/hotspot/share/nmt/nmtNativeCallStackStorage.hpp line 84:
> 
>> 82:       return *_stack;
>> 83:     }
>> 84:   };
> 
> What is the point of the StackIndex class?

The `StackIndex` used to be a 4 byte encoding which required the `NativeCallStackStorage` to be able to be dereferenced. This method should at the very least be deleted and replaced with `NativeCallStackStorage::get`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1535848809


More information about the hotspot-dev mailing list