RFR: 8327652: S390x: Implements SLP support [v7]

[Lutz Schmidt]

On Fri, 8 Mar 2024 05:35:06 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Sidraya Jayagond has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   PopCountVI supported by z14 onwards.
>
> src/hotspot/cpu/s390/sharedRuntime_s390.cpp line 485:
> 
>> 483:     offset += reg_size;
>> 484:   }
>> 485:   assert(offset == frame_size_in_bytes, "consistency check");
> 
> Suggestion:
> 
> #ifdef ASSERT
>   assert(offset == frame_size_in_bytes, "consistency check");
> #endif // ASSERT

Why this change? 
You use #ifdef ASSERT blocks only if it is impractical to pack all the code into an assert() macro call.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18162#discussion_r1537899408