RFR: 8314225: SIGSEGV in JavaThread::is_lock_owned [v3]

Kevin Walls kevinw at openjdk.org
Wed May 1 11:04:22 UTC 2024


On Wed, 1 May 2024 10:04:33 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> src/hotspot/share/runtime/javaThread.cpp line 1051:
>> 
>>> 1049:   assert(LockingMode != LM_LIGHTWEIGHT, "should not be called with new lightweight locking");
>>> 1050:   return Thread::is_lock_owned(adr);
>>> 1051: }
>> 
>> Can't we just remove `JavaThread::is_lock_owned` now?
>
> Yes I was thinking about that - it just defers to Thread::is_lock_owned and that has the same assert.  I will remove it.

Updated with this removal.  
Thread::is_lock_owned had a comment above it from jdk5 or before, referring to JavaThread::is_lock_owned, which I removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18940#discussion_r1586179476


More information about the hotspot-dev mailing list