RFR: 8314225: SIGSEGV in JavaThread::is_lock_owned [v2]

Kevin Walls kevinw at openjdk.org
Wed May 1 10:06:53 UTC 2024


On Wed, 1 May 2024 09:44:41 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Feedback from Dean
>
> src/hotspot/share/runtime/javaThread.cpp line 1051:
> 
>> 1049:   assert(LockingMode != LM_LIGHTWEIGHT, "should not be called with new lightweight locking");
>> 1050:   return Thread::is_lock_owned(adr);
>> 1051: }
> 
> Can't we just remove `JavaThread::is_lock_owned` now?

Yes I was thinking about that - it just defers to Thread::is_lock_owned and that has the same assert.  I will remove it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18940#discussion_r1586123494


More information about the hotspot-dev mailing list