RFR: 8314225: SIGSEGV in JavaThread::is_lock_owned [v3]

David Holmes dholmes at openjdk.org
Wed May 1 21:55:54 UTC 2024


On Wed, 1 May 2024 21:22:15 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove JavaThread's is_lock_owned
>
> src/hotspot/share/runtime/thread.cpp line 530:
> 
>> 528: #endif // ASSERT
>> 529: 
>> 530: bool Thread::is_lock_owned(address adr) const {
> 
> Is there any reason not to move this to JavaThread now?  Also, I don't think it needs to be virtual.

Good point. Only JavaThread's can own ObjectMonitors.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18940#discussion_r1586866888


More information about the hotspot-dev mailing list