RFR: 8326306: RISC-V: Re-structure MASM calls and jumps [v2]

Fei Yang fyang at openjdk.org
Thu May 2 23:19:51 UTC 2024


On Thu, 2 May 2024 07:06:51 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> We still need relocates rt_call, not sure why you removed it.

I removed the relocate because I am thinking it should be absolute calls in the else block of `MacroAssembler::rt_call` [1], so no reloc required, as you mentioned in your previous comments. 

[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/riscv/macroAssembler_riscv.cpp#L5027

> It seem like we need two version of rt_call one with address and one with Address. Then it seem like we could remove far_call as the rt_call would do the right thing.
> 
> I like your idea, and we should do that, but it seems like it's not trivial just to add to this patch. Is there a reason we need to include such in changes in this PR?

On holiday this week, we can discuss further next week :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18942#discussion_r1588519824


More information about the hotspot-dev mailing list