RFR: 8326306: RISC-V: Re-structure MASM calls and jumps [v2]

Robbin Ehn rehn at openjdk.org
Thu May 2 07:09:53 UTC 2024


On Thu, 2 May 2024 06:48:04 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Off today, I'll have a look tomorrow, thanks.
>
> Yes, we should use is_32bit_offset_from_codecache to use auipc as much as possible.
> As there is much churn in this patch and our testing takes so long I was trying to keep assembly same to avoid bisecting down issues.
> 
> It's much better with just two calls, either rt call or VM leaf.
> 
> I'll test your patch, thanks.

We still need relocates rt_call, not sure why you removed it.
It seem like we need two version of rt_call one with address and one with Address.
Then it seem like we could remove far_call as the rt_call would do the right thing.

I like your idea, and we should do that, but it seems like it's not trivial just to add to this patch.
Is there a reason we need to include such in changes in this PR?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18942#discussion_r1587163354


More information about the hotspot-dev mailing list