RFR: 8326306: RISC-V: Re-structure MASM calls and jumps [v8]

Robbin Ehn rehn at openjdk.org
Tue May 7 14:12:56 UTC 2024


On Tue, 7 May 2024 13:53:41 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use li instead of movptr for call
>
> src/hotspot/cpu/riscv/jniFastGetField_riscv.cpp line 178:
> 
>> 176:     ExternalAddress target(slow_case_addr);
>> 177:     __ relocate(target.rspec(), [&] {
>> 178:       __ call(target.target());
> 
> Should we revert this change after your last commit? As I think call is now not necessarily la + jalr.

The addresses should come from JNI_FastGetField::generate_fast_get_XXX_field0.
So slow_case_addr is not really an ExternalAddress.
This means call will always do auipc + jalr as you know (intra code cache).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18942#discussion_r1592552786


More information about the hotspot-dev mailing list