RFR: 8326306: RISC-V: Re-structure MASM calls and jumps [v8]

[Fei Yang]

On Tue, 7 May 2024 14:10:03 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/jniFastGetField_riscv.cpp line 178:
>> 
>>> 176:     ExternalAddress target(slow_case_addr);
>>> 177:     __ relocate(target.rspec(), [&] {
>>> 178:       __ call(target.target());
>> 
>> Should we revert this change after your last commit? As I think call is now not necessarily la + jalr.
>
> The addresses should come from JNI_FastGetField::generate_fast_get_XXX_field0.
> So slow_case_addr is not really an ExternalAddress.
> This means call will always do auipc + jalr as you know (intra code cache).

Hmm... So I did a quick try on linux-aarch64 invoking `CodeCache::contains` on slow_case_addr and the result is false. Anything I missed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18942#discussion_r1593392866