RFR: 8326306: RISC-V: Re-structure MASM calls and jumps [v10]

Robbin Ehn rehn at openjdk.org
Mon May 13 07:40:16 UTC 2024


On Mon, 13 May 2024 04:05:26 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jal-fixes
>>  - Revert JNI field, call()->li()
>>  - Use li instead of movptr for call
>>  - REVERT: Use li instead of movptr
>>  - Use li instead of movptr
>>  - VM leaf should use li
>>  - Merge branch 'master' into jal-fixes
>>  - Merge branch 'master' into jal-fixes
>>  - Merge branch 'master' into jal-fixes
>>  - Corrected method name
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/e688815a...d53e9694
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 738:
> 
>> 736:   typedef void (MacroAssembler::* load_insn_by_temp)(Register Rt, address dest, Register temp);
>> 737: 
>> 738:   void wrap_label(Register r, Label &L, Register t, load_insn_by_temp insn);
> 
> Better to remove the `load_insn_by_temp` declaration from file macroAssembler_riscv.hpp as it is not used anymore after this change.
> 
> `typedef void (MacroAssembler::* load_insn_by_temp)(Register Rt, address dest, Register temp);`

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18942#discussion_r1598009838


More information about the hotspot-dev mailing list