RFR: 8326306: RISC-V: Re-structure MASM calls and jumps [v10]

Robbin Ehn rehn at openjdk.org
Mon May 13 08:02:39 UTC 2024


On Mon, 13 May 2024 04:09:36 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jal-fixes
>>  - Revert JNI field, call()->li()
>>  - Use li instead of movptr for call
>>  - REVERT: Use li instead of movptr
>>  - Use li instead of movptr
>>  - VM leaf should use li
>>  - Merge branch 'master' into jal-fixes
>>  - Merge branch 'master' into jal-fixes
>>  - Merge branch 'master' into jal-fixes
>>  - Corrected method name
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/41e8083a...d53e9694
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 717:
> 
>> 715:     return x < (twoG - twoK) && x >= (-twoG - twoK);
>> 716:   }
>> 717: 
> 
> Can you add a code comment for this new function (`is_32bit_offset_from_codecache`) to make it easier to understand? Maybe something like:
> `Ensure that the auipc can reach the destination at x from anywhere within the code cache so that if it is relocated we know it will still reach.`

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18942#discussion_r1598037295


More information about the hotspot-dev mailing list