RFR: 8312132: Add tracking of multiple address spaces in NMT [v74]
Johan Sjölen
jsjolen at openjdk.org
Tue May 14 15:54:17 UTC 2024
On Thu, 9 May 2024 11:35:29 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> And I would not rely on the internal verification here, but call verify explicitly. (see also note in treap add/remove about verification)
>
> Please also test the scoped find function with different sets (eg. empty set, 1 item set etc).
I've added a fair amount of tests to this code now. I still need to add some more for iterators, at least the closest_leq. Most of the tests use `int` (so not `size_t`), I wrote the `find` tests using `float` instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1600281887
More information about the hotspot-dev
mailing list