RFR: 8312132: Add tracking of multiple address spaces in NMT [v74]

[Thomas Stuefe]

On Thu, 9 May 2024 11:25:58 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> test/hotspot/gtest/nmt/test_nmt_treap.cpp line 57:
>> 
>>> 55:       treap.remove(i);
>>> 56:     }
>>> 57:   }
>> 
>> Please test the find functions (leq, geq etc) and iteration.
>> 
>> For the latter, please test that we see every value, guaranteed, and that we see every value only exactly once.
>> 
>> Also test:
>> - inserting duplicates should result in only one value
>> - empty treap should work as expected
>> - treap with custom allocator, e.g. a simple array based one. Make sure we don't leak memory after nodes are removed, or after remove_all
>> - treap with different custom comparator, please counter check the iteration order
>> - maybe some more types? at least the common numericals
>
> And I would not rely on the internal verification here, but call verify explicitly. (see also note in treap add/remove about verification)

Please also test the scoped find function with different sets (eg. empty set, 1 item set etc).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1595332326