RFR: 8332265: RISC-V: Materialize pointers faster by using a temp register [v2]
Ludovic Henry
luhenry at openjdk.org
Tue May 21 08:02:08 UTC 2024
On Tue, 21 May 2024 05:52:48 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - li48 -> movptr
>> - Merge branch 'master' into 8332265
>> - li48
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 1426:
>
>> 1424: }
>> 1425:
>> 1426: static int patch_addr_in_movptr2(address instruction_address, address target) {
>
> Can we have a common entry of `patch_addr_in_movptr` which delegates work to `patch_addr_in_movptr1` and `patch_addr_in_movptr2`?
I think it makes sense to split them up as the difference between movptr1 and movptr2 is already done in the caller then. And IIUC we don't plan to merge movptr1 and movptr2 together at any point, so we don't particularly need to abstract them away.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19246#discussion_r1607822360
More information about the hotspot-dev
mailing list