RFR: 8312132: Add tracking of multiple address spaces in NMT [v97]

[Johan Sjölen]

On Wed, 22 May 2024 17:18:10 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> src/hotspot/share/nmt/nmtTreap.hpp line 236:
>> 
>>> 234:   }
>>> 235: 
>>> 236:   void upsert(const K& k, const V& v) {
>> 
>> Could we rename this to simply `add()` instead of `upsert()` ?
>
> I would take `insert()` over `upsert()` too, if you don't like `add()` :-)

I really prefer `upsert` over `insert`, the point is to show that it works for both *up*dating and in*sert*ing! It is pretty well established in database terminology. I can go with `add` if you're not comfortable with `upsert`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18289#discussion_r1611609405