RFR: 8330198: Add some class loading related perf counters to measure VM startup [v3]
David Holmes
dholmes at openjdk.org
Thu May 23 22:36:11 UTC 2024
On Thu, 23 May 2024 22:17:43 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>>
>> comments from Ioi
>
> src/hotspot/share/classfile/classLoader.cpp line 1477:
>
>> 1475:
>> 1476: jlong ClassLoader::class_init_count() {
>> 1477: return (UsePerfData) ? _perf_classes_inited->get_value() : -1;
>
> No need to add brackets here
Surely this needs to be checking `ProfileClassLinkage`, which in turn should be false if `UsePerfData` is false.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18790#discussion_r1612399712
More information about the hotspot-dev
mailing list