RFR: 8332265: RISC-V: Materialize pointers faster by using a temp register [v6]

Robbin Ehn rehn at openjdk.org
Fri May 24 12:45:04 UTC 2024


On Fri, 24 May 2024 10:55:27 GMT, Hamlin Li <mli at openjdk.org> wrote:

> And a general question about `nativeInst_riscv.cpp` and `macroAssembler_riscv.cpp`. I saw the functions in these 2 files call each other, that make the code a bit mess to me. It's not an issue introduced in this pr. I wonder if this could be refactored? If so, I can work on it. But just in case you have easy answer already, so I don't have to do further investigation.

I agree, I would prefer having classes for the instruction where all the instruction functionality would be.
As it's now the opcodes are reapted everywhere, instead it should just be in in-place, this class.
And then have classes for instruction sequence where we keep all functionality gathered.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19246#issuecomment-2129438142


More information about the hotspot-dev mailing list