RFR: 8332900: RISC-V: refactor nativeInst_riscv.cpp and macroAssembler_riscv.cpp [v3]

Hamlin Li mli at openjdk.org
Fri May 31 14:40:15 UTC 2024


On Fri, 31 May 2024 13:42:36 GMT, Fei Yang <fyang at openjdk.org> wrote:

> LGTM modulo one minor comment. I think you are right in this refactoring work. Sorry for mis-understanding your opinion. Thanks!

No worry. Thanks for discussion!

> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 99:
> 
>> 97:   }
>> 98: 
>> 99:  private:
> 
> Maybe it's better to make those is_XXX functions public in case of possible future uses in other places?

Yes, modified.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19459#issuecomment-2142393896
PR Review Comment: https://git.openjdk.org/jdk/pull/19459#discussion_r1622521815


More information about the hotspot-dev mailing list