RFR: 8342818: Implement CPU Time Profiling for JFR [v12]
Johannes Bechberger
jbechberger at openjdk.org
Wed Nov 6 13:32:40 UTC 2024
On Wed, 6 Nov 2024 13:20:02 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
>> That makes sense. But can I just keep the code that I wrote then?
>
> Can't you do the same as ObjectAllocationSample and OldObjectSample? They are not periodic and have throttle/cutoff.
And they set a `<setting name="stackTrace">true</setting>` in the settings. But this doesn't make sense here, because without a stacktrace, a sample is not really that useful.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1831021006
More information about the hotspot-dev
mailing list