RFR: 8342818: Implement CPU Time Profiling for JFR [v13]
Erik Gahlin
egahlin at openjdk.org
Wed Nov 6 13:55:42 UTC 2024
On Wed, 6 Nov 2024 13:29:43 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:
>> Can't you do the same as ObjectAllocationSample and OldObjectSample? They are not periodic and have throttle/cutoff.
>
> And they set a `<setting name="stackTrace">true</setting>` in the settings. But this doesn't make sense here, because without a stacktrace, a sample is not really that useful.
If you disable the stackTrace, you will still get the thread. Perhaps not that useful, but that could be said about many events that have a stack trace. I think we should keep it consistent.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1831056487
More information about the hotspot-dev
mailing list