RFR: 8342818: Implement CPU Time Profiling for JFR [v13]

[Johannes Bechberger]

On Wed, 6 Nov 2024 13:51:59 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> And they set a `<setting name="stackTrace">true</setting>` in the settings. But this doesn't make sense here, because without a stacktrace, a sample is not really that useful.
>
> If you disable the stackTrace, you will still get the thread. Perhaps not that useful, but that could be said about many events that have a stack trace. I think we should keep it consistent.

But doesn't the user expect that they get a stack trace when they write a settings file with:


<event name="jdk.CPUTimeSample">
    <setting name="enabled">true</setting>
    <setting name="throttle">150/s</setting>
  </event>


Because when they write


<event name="jdk.ExecutionSample">
    <setting name="enabled">true</setting>
    <setting name="period">10ms</setting>
  </event>


They also get one. So I think we should not force the user to set the stacktrace.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1831071723