RFR: 8344381: [s390x] Test failures with error: Register type is not known [v2]

Amit Kumar amitkumar at openjdk.org
Tue Nov 19 05:24:26 UTC 2024


On Mon, 18 Nov 2024 21:18:03 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> This makes sense. Only volatile registers which are allocated need to be saved and restored. You could also use `is_volatile()` functions from the `Register` class. The registers which are not allocated should not show up here because we get them from `live_regs_iterator.next()`. So, I think there's no need to filter them out. But you can filter them out. I have no objects. I had basically asked because of readability reasons. Sorry if my question was a bit confusing.

No I guess your question was perfectly correct. My concept for "which register needs to be preserved" was a bit on the loose. But now I got idea. So thanks for that.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22197#issuecomment-2484655449


More information about the hotspot-dev mailing list