RFR: 8342769: HotSpot Windows/gcc port is broken [v3]

[Julian Waters]

On Wed, 20 Nov 2024 08:42:09 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight within SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely
>
> Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into hotspot
>  - Revert sharedRuntime.cpp
>  - Revert sharedRuntime_x86.cpp
>  - 8342769

I've changed the check to instead define the constants when _M_ARM64 is defined. This is the cleanest approach I can come up with, and doesn't touch the workaround code in frem and drem either

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21627#issuecomment-2487907476