RFR: 8344010: RISC-V: Zacas do not work with LW locking

Hamlin Li mli at openjdk.org
Wed Nov 20 09:56:22 UTC 2024


On Wed, 20 Nov 2024 06:25:27 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> The "mv()" check that for you, so an e.g. mv(a0, a0) will never emit an instruction.
>> 
>> OT NOTE:
>> If you are in an InCompressableRegion this will still not emit an instruction so your offsets may be wrong.
>
> Oh, sorry I now see what you mean.
> As the mv is just register rename it make little different and I want to update this code to sort more things out, adding yet another if-statemet just comes in the way.
> 
> I want to clean it up before we micro optimize it.

I see, let's do this optimization later after the fixing of these bugs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22149#discussion_r1849987269


More information about the hotspot-dev mailing list