RFR: 8343767: Enumerate StubGen blobs, stubs and entries and generate code from declarations

[Fei Yang]

On Thu, 7 Nov 2024 14:54:32 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

> Implementation of JDK-8343767

Hi, Nice work! I am testing this on linux-riscv64 platform. Several minor comments about the riscv part after a cursory look.

src/hotspot/cpu/riscv/stubDeclarations_riscv.hpp line 37:

> 35:   do_arch_entry(riscv, initial, get_previous_sp,                        \
> 36:                 get_previous_sp_entry,                                  \
> 37:                 get_previous_sp_entry)                                  \

`get_previous_sp_entry` has been removed by https://bugs.openjdk.org/browse/JDK-8344265.

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 1117:

> 1115:   //   used by generate_conjoint_int_oop_copy().
> 1116:   //
> 1117:   address generate_disjoint_copy(StubGenStubId stub_id, address* entry) {

Preceding code comment needs update to reflect the new parameters.

src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 1265:

> 1263:   // cache line boundaries will still be loaded and stored atomically.
> 1264:   //
> 1265:   address generate_conjoint_copy(StubGenStubId stub_id, address nooverlap_target, address *entry) {

Preceding code comment needs update to reflect the new parameters.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21957#pullrequestreview-2450083528
PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1851489835
PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1851223868
PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1851224210