RFR: 8342769: HotSpot Windows/gcc port is broken [v6]

[Julian Waters]

On Thu, 21 Nov 2024 10:10:33 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revise comment in sharedRuntime.hpp
>
> test/hotspot/gtest/runtime/test_os.cpp line 766:
> 
>> 764:       ASSERT_EQ(mapping_info.regions, 1);
>> 765:       ASSERT_EQ(mapping_info.size, total_range_len);
>> 766:       ASSERT_EQ(mapping_info.committed_size, size_t { 0 });
> 
> Suggestion:
> 
>       ASSERT_EQ(mapping_info.committed_size, size_t{0});
> 
> We don't usually insert extra spaces. Was there a special reason?

No, there wasn't really a reason other than the formatting looked neater. But since the style is to usually not leave spaces, I'll commit the suggestion and fix the other areas too

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1853497821