RFR: 8342769: HotSpot Windows/gcc port is broken [v6]

[Andrew Haley]

On Thu, 21 Nov 2024 06:41:33 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight within SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revise comment in sharedRuntime.hpp

test/hotspot/gtest/runtime/test_os.cpp line 766:

> 764:       ASSERT_EQ(mapping_info.regions, 1);
> 765:       ASSERT_EQ(mapping_info.size, total_range_len);
> 766:       ASSERT_EQ(mapping_info.committed_size, size_t { 0 });

Suggestion:

      ASSERT_EQ(mapping_info.committed_size, size_t{0});

We don't usually insert extra spaces. Was there a special reason?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1851749057