RFR: 8340731: Cleanup remaining IA64 references in hotspot code [v3]

David Holmes dholmes at openjdk.org
Wed Nov 27 05:00:38 UTC 2024


On Tue, 26 Nov 2024 07:29:48 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> src/hotspot/share/runtime/javaCalls.cpp line 121:
>> 
>>> 119:   // Do this after the transition because this allows us to put an assert
>>> 120:   // the Java->vm transition which checks to see that stack is not walkable
>>> 121:   // which will catch violations of the resetting of last_Java_frame
>> 
>> Not clear the comment is still valid given we no longer have sparc or ia64 support.
>
> should I remove this whole comment then ?

Yes please. I can't see anything related to "not walkable" in the thread state transition code. I checked back to Java 8.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22382#discussion_r1859923684


More information about the hotspot-dev mailing list