RFR: 8345047: RISC-V: Remove explicit use of AvoidUnalignedAccesses in interpreter

Fei Yang fyang at openjdk.org
Wed Nov 27 10:28:43 UTC 2024


On Tue, 26 Nov 2024 11:15:29 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi, please consider this small interpreter cleanup change.
>> 
>> The use of `AvoidUnalignedAccesses` option for these cases doen't much sense to me.
>> MacroAssembler routines like `revb_h_h_u` and `revb_h_h` will emit 5 instructions when Zbb extension is not available. This is more than the case when `AvoidUnalignedAccesses` option is true. After this change, we always emit 4 instructions compared to 3 instructions in the case when we have Zbb extension. But I don't think it will make a difference.
>> 
>> Testing on linux-riscv64 platform:
>> - [x] tier1 (release)
>
> Looks good. Thanks!
> Since the changes are in the interpreter, I can accept minor regressions introduced in exchange for code readability.

@Hamlin-Li @feilongjiang : Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22387#issuecomment-2503497981


More information about the hotspot-dev mailing list