RFR: 8340241: RISC-V: Returns mispredicted [v8]

Robbin Ehn rehn at openjdk.org
Mon Oct 14 13:31:13 UTC 2024


On Mon, 14 Oct 2024 13:23:59 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp line 1475:
>> 
>>> 1473:     Label L_skip_barrier;
>>> 1474:     __ mov_metadata(t0, method->method_holder()); // InstanceKlass*
>>> 1475:     __ clinit_barrier(t0, t1, &L_skip_barrier);
>> 
>> What is this change for?
>
> Some clinit_barrier used "t0, t1" and some "t1,t0" I was just annoyed that they were different.

See there is still one odd one here, sharedRuntime_riscv.cpp L2849.
I can revert or change that one also ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21406#discussion_r1799514753


More information about the hotspot-dev mailing list