RFR: 8340241: RISC-V: Returns mispredicted [v8]
Fei Yang
fyang at openjdk.org
Mon Oct 14 13:53:18 UTC 2024
On Mon, 14 Oct 2024 13:28:50 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Some clinit_barrier used "t0, t1" and some "t1,t0" I was just annoyed that they were different.
>
> See there is still one odd one here, sharedRuntime_riscv.cpp L2849.
> I can revert or change that one also ?
Ah, I see. I would prefer to keep the original shape. As you see, the first param for `MacroAssembler::clinit_barrier` is `klass` which is supposed to be alive for quite a range (used across the routine). I think `t1` is safer here because `t0` is implictly clobbered by various assember routines.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21406#discussion_r1799550960
More information about the hotspot-dev
mailing list