RFR: 8341452: Test runtime/cds/appcds/DumpRuntimeClassesTest.java from JDK-8324259 is failing [v5]

[Ioi Lam]

On Wed, 16 Oct 2024 05:04:12 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed unused include
>
> src/hotspot/share/cds/cdsProtectionDomain.cpp line 212:
> 
>> 210: }
>> 211: 
>> 212: oop CDSProtectionDomain::get_shared_jar_url_helper(const char* path, Handle url_h, TRAPS) {
> 
> Suggestion:
> 
> oop CDSProtectionDomain::get_file_URL(const char* path, Handle url_h, TRAPS) {
> 
> It looks odd to have a "helper" method as part of the public API, especially when called directly.

I think both function can use the same name, since they have overloaded parameter types:


Handle CDSProtectionDomain::get_shared_jar_url(int shared_path_index, TRAPS);
oop CDSProtectionDomain::get_shared_jar_url(const char* path, Handle url_h, TRAPS);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21329#discussion_r1802377534