RFR: 8341527: AVX-512 intrinsic for SHA3 [v4]

[Sandhya Viswanathan]

On Tue, 22 Oct 2024 11:44:30 GMT, Ferenc Rakoczi <duke at openjdk.org> wrote:

>>> This is not a review but I've run some testing with the current patch and found the following two failures on linux-x64-debug:
>>> 
>> 
>> @chhagedorn could you send me the mach5 command line (or other means) to run these tests?
>
>> @ferakocz I think you need to enble SHA3 testing in jtreg tests we have by modifying: https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/testlibrary/sha/predicate/IntrinsicPredicates.java#L106
>> 
>> [JDK-8252204](https://bugs.openjdk.org/browse/JDK-8252204) added several C2 tests for SHA3 intrinsics in `test/hotspot/jtreg/compiler/intrinsics/sha`. Please make sure your changes passed those tests.
> 
> I did that, plus restored the error message, now all the tests suggested by @chhagedorn pass.

@ferakocz Thanks for taking my inputs into consideration and the corresponding changes. Would it be also possible for you to add comments to the rounds24_loop code if you want us to review that in detail. Otherwise the PR looks good to me.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21352#issuecomment-2435668971