RFR: 8341527: AVX-512 intrinsic for SHA3 [v4]

[Ferenc Rakoczi]

On Thu, 24 Oct 2024 15:54:27 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:

>>> @ferakocz I think you need to enble SHA3 testing in jtreg tests we have by modifying: https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/compiler/testlibrary/sha/predicate/IntrinsicPredicates.java#L106
>>> 
>>> [JDK-8252204](https://bugs.openjdk.org/browse/JDK-8252204) added several C2 tests for SHA3 intrinsics in `test/hotspot/jtreg/compiler/intrinsics/sha`. Please make sure your changes passed those tests.
>> 
>> I did that, plus restored the error message, now all the tests suggested by @chhagedorn pass.
>
> @ferakocz Thanks for taking my inputs into consideration and the corresponding changes. Would it be also possible for you to add comments to the rounds24_loop code if you want us to review that in detail. Otherwise the PR looks good to me.

@sviswa7 and @vpaprotsk, I added comments to the algorithm implementation, could you take another look and approve again if you are satisfied with them? Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21352#issuecomment-2441003262