RFR: 8334999: RISC-V: implement AES single block encryption/decryption intrinsics [v9]

Arseny Bochkarev duke at openjdk.org
Thu Oct 24 21:55:19 UTC 2024


On Tue, 22 Oct 2024 10:00:26 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Arseny Bochkarev has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available.
>
> src/hotspot/share/opto/library_call.cpp line 7229:
> 
>> 7227:   // Intel's extension is based on this optimization and AESCrypt generates round keys by preprocessing MixColumns.
>> 7228:   // However, ppc64 vncipher processes MixColumns and requires the same round keys with encryption.
>> 7229:   // The ppc64 and RISCV64 stubs of encryption and decryption use the same round keys (sessionK[0]).
> 
> Nit: A small `riscv64` will do here.
> 
> // The ppc64 and riscv64 stubs of encryption and decryption use the same round keys (sessionK[0]).
> 
> 
> (PS: Please also merge with latest jdk master)

All done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19960#discussion_r1815732972


More information about the hotspot-dev mailing list