RFR: 8342818: Implement CPU Time Profiling for JFR [v2]

Johannes Bechberger jbechberger at openjdk.org
Wed Oct 30 18:13:17 UTC 2024


On Wed, 30 Oct 2024 04:21:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve TestLookForUntestedEvents and TimespanRate.of
>
> src/hotspot/share/jfr/recorder/stacktrace/jfrAsyncStackTrace.cpp line 56:
> 
>> 54:   }
>> 55:   assert(current_thread->in_asgct(), "invariant");
>> 56:   assert(jt != current_thread || current_thread->in_asgct(), "invariant");
> 
> The second clause of the second assert is redundant given the first assert.

The second assert is redundant.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1823157378


More information about the hotspot-dev mailing list