RFR: 8342818: Implement CPU Time Profiling for JFR [v4]

David Holmes dholmes at openjdk.org
Thu Oct 31 02:59:34 UTC 2024


On Wed, 30 Oct 2024 18:07:22 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

>> Similarity to the other sampler.
>
> And it's far easier to read.

I certainly disagree on the readability aspect. The switch means I have to look through each section to figure out what it does for each state. In contrast:

state = ...
return state == _thread_in_Java || state == _thread_in_Java_trans;
``
is IMO blindingly obvious.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1823713022


More information about the hotspot-dev mailing list