RFR: 8342818: Implement CPU Time Profiling for JFR [v4]

[David Holmes]

On Wed, 30 Oct 2024 07:31:02 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

>> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 41:
>> 
>>> 39: #include "runtime/osThread.hpp"
>>> 40: 
>>> 41: #if defined(LINUX)
>> 
>> If this is all Linux specific then can't we put it in a linux-specific sourcefile instead of masquerading as shared code?
>
> The idea is to place it close to the other method sampler.

Why? Large chunks of platform specific code should be in platform specific files. That is the way hotspot sources are arranged.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1823716347