RFR: 8339466: Enumerate shared stubs and define static fields and names via declarations [v4]

[Vladimir Kozlov]

On Wed, 4 Sep 2024 11:10:36 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Systematize handling of SharedRuntime stubs. Generate enum ids, static fields and names from declarations using template macros. Systematically reference stubs and stub names using ids.
>
> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   clean up asserts

Few comments.

src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 2184:

> 2182:   }
> 2183: #endif
> 2184:   const char *name = SharedRuntime::stub_name(SharedStubId::deopt_id);

Code style: `const char* name`

src/hotspot/share/runtime/sharedRuntime.hpp line 66:

> 64: #undef SHARED_STUB_FIELD_DECLARE
> 65: 
> 66: #ifndef PRODUCT

Use `#ifdef ASSERT` here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/20832#pullrequestreview-2281512904
PR Review Comment: https://git.openjdk.org/jdk/pull/20832#discussion_r1744577365
PR Review Comment: https://git.openjdk.org/jdk/pull/20832#discussion_r1744579368