RFR: 8339466: Enumerate shared stubs and define static fields and names via declarations [v4]

[Andrew Dinn]

On Wed, 4 Sep 2024 22:20:31 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   clean up asserts
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 2184:
> 
>> 2182:   }
>> 2183: #endif
>> 2184:   const char *name = SharedRuntime::stub_name(SharedStubId::deopt_id);
> 
> Code style: `const char* name`

Done here and at all other occurrences.

> src/hotspot/share/runtime/sharedRuntime.hpp line 66:
> 
>> 64: #undef SHARED_STUB_FIELD_DECLARE
>> 65: 
>> 66: #ifndef PRODUCT
> 
> Use `#ifdef ASSERT` here.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20832#discussion_r1745204621
PR Review Comment: https://git.openjdk.org/jdk/pull/20832#discussion_r1745205133