RFR: 8339790: Support Intel APX setzucc instruction [v4]
Vladimir Kozlov
kvn at openjdk.org
Mon Sep 16 21:08:13 UTC 2024
On Mon, 16 Sep 2024 20:45:45 GMT, Sandhya Viswanathan <sviswanathan at openjdk.org> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review comments resolution.
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 10426:
>
>> 10424:
>> 10425: void MacroAssembler::setcc(Assembler::Condition comparison, Register dst) {
>> 10426: if (VM_Version::supports_apx_f()) {
>
> We could check UseAPX here instead of VM_Version::supports_apx_f().
I think switching off a feature in `vm_version` file based on flags setting is correct.
So that in the rest of code we can simple check `VM_Version::supports_*()`.
Currently not all code follow this but it is preferable way.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20920#discussion_r1761963930
More information about the hotspot-dev
mailing list