RFR: 8322770: Implement C2 VectorizedHashCode on AArch64 [v11]
Mikhail Ablakatov
duke at openjdk.org
Tue Sep 24 12:54:25 UTC 2024
On Tue, 24 Sep 2024 10:28:49 GMT, Mikhail Ablakatov <duke at openjdk.org> wrote:
>> It's untested. What I'm trying to say is that we shouldn't duplicate stuff. Perhaps I should have been clearer.
>>
>> Separate the fields into what is the same, and what is different. Put the different inside the if. Put the common outside the if.
>
> The only matching field out of the sequence of four under the if/else is `f(op2, 15, 12)`, but OK, I can hoist it if this makes things clearer.
Fixed by https://github.com/openjdk/jdk/pull/18487/commits/a28bbcd3bbe7555e715b107b71c18efaf72a7ce7.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18487#discussion_r1773284185
More information about the hotspot-dev
mailing list