RFR: 8322770: Implement C2 VectorizedHashCode on AArch64 [v11]

Mikhail Ablakatov duke at openjdk.org
Tue Sep 24 10:31:45 UTC 2024


On Tue, 24 Sep 2024 10:06:31 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Looks like that's incorrect: the 22th-23th bits and 11th bits differ.
>
> It's untested. What I'm trying to say is that we shouldn't duplicate stuff. Perhaps I should have been clearer.
> 
> Separate the fields into what is the same, and what is different. Put the different inside the if. Put the common outside the if.

The only matching field out of the sequence of four under the if/else is `f(op2, 15, 12)`, but OK, I can hoist it if this makes things clearer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18487#discussion_r1773078306


More information about the hotspot-dev mailing list