RFR: 8322770: Implement C2 VectorizedHashCode on AArch64 [v14]

[Mikhail Ablakatov]

On Tue, 24 Sep 2024 15:00:58 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Mikhail Ablakatov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   cleanup: fix a comment typo
>>   
>>   Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
>
> src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.hpp line 39:
> 
>> 37:   // Helper functions for arrays_hashcode.
>> 38:   void arrays_hashcode_elload(Register dst, Address src, BasicType eltype);
>> 39:   int arrays_hashcode_elsize(BasicType eltype);
> 
> The above two methods don't seem to exist any more?

Fixed by https://github.com/openjdk/jdk/pull/18487/commits/0a0ab92a1e6f722bc0feaaa6787d15d734fed392.

> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 5477:
> 
>> 5475: 
>> 5476:     assert(is_power_of_2(vf), "can't use this value to calculate the jump target PC");
>> 5477:     __ andr(rscratch2, cnt, vf - 1);
> 
> It would probably be helpful to include here a repeat of the comment you added to the macroassembler method explaining how this deals with the correct number of leftover elements modulo `vf`

Fixed by https://github.com/openjdk/jdk/pull/18487/commits/142fa5d0822910ca979de60aef62ba390365afc3.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18487#discussion_r1775514892
PR Review Comment: https://git.openjdk.org/jdk/pull/18487#discussion_r1775515932