RFR: 8340974: Ambiguous name of jtreg property vm.libgraal.enabled

Doug Simon dnsimon at openjdk.org
Thu Sep 26 07:26:35 UTC 2024


On Wed, 25 Sep 2024 19:49:28 GMT, Todd V. Jonker <duke at openjdk.org> wrote:

> This disambiguates the situation where libgraal is "enabled" for use by non-CompilerBroker compilations, without being used as the JIT compiler.
> 
> Per discussion at https://github.com/openjdk/jdk/pull/21120#issuecomment-2372462365 
> 
> Grep shows that the property and related method are not used in this codebase.  Tier1 tests on linux-x86_64-server-release pass cleanly.

test/jtreg-ext/requires/VMProps.java line 562:

> 560:      * @return true if libgraal is used as JIT compiler.
> 561:      */
> 562:     protected String isLibgraalJit() {

I slightly prefer `isLibgraalJIT` as this acronym is (most) capitalized in the code base.

You should also rename `isLibgraalEnabled` to `isLibgraalJIT` in `test/lib/jdk/test/whitebox/code/Compiler.java` for consistency.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21190#discussion_r1776521228


More information about the hotspot-dev mailing list