RFR: 8340974: Ambiguous name of jtreg property vm.libgraal.enabled [v2]

Todd V. Jonker duke at openjdk.org
Thu Sep 26 17:49:50 UTC 2024


On Thu, 26 Sep 2024 07:23:35 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> Todd V. Jonker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename Compiler.isLibgraalEnabled to isLibgraalJIT
>
> test/jtreg-ext/requires/VMProps.java line 562:
> 
>> 560:      * @return true if libgraal is used as JIT compiler.
>> 561:      */
>> 562:     protected String isLibgraalJit() {
> 
> I slightly prefer `isLibgraalJIT` as this acronym is (most) capitalized in the code base.
> 
> You should also rename `isLibgraalEnabled` to `isLibgraalJIT` in `test/lib/jdk/test/whitebox/code/Compiler.java` for consistency.

Renamed both. I was being conservative by limiting scope of change to the relevant interface, and felt that the existing name was reasonable in the `Compiler` scope.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21190#discussion_r1777513248


More information about the hotspot-dev mailing list